Just wondering if i doing this right

[SirThorfinn]

For my FPS i want to have weapon switching and i was just experimenting in a separate world. Would you please tell if these methods for it are good if so i'm going to use it in my game.
Wepon switching.a2w

[Dameria]

A lot of your methods are unnecessary, for example you have different "take out" and "put away" methods for each gun. You could have world method for "take out" and "put away" and even firing by using parameters, and by using the parameters for if/else statements within the methods to choose which gun to take out, all in 1 method.

[SirThorfinn]

The only reason the weapons had different take out and put away methods was because i wanted them to come up to the screen in different ways depending on the gun, plus the Glock had a weird center point so i had to make one for it anyway.

[debussybunny563]

It's nice, but there's a bug with the M1014 and Glock that you can have both out at once. I think it has to do with shooting and switching weapons at the same time; having variables governing those will eliminate that (e.g. If <shooting> == <false>, weapon.switch; Else, Do Nothing;;If <switching> == <false>, weapon.shoot; Else, Do Nothing)

Anyway, D-dog's right; in my FPS I used one method with If/Elses to determine which weapon should be drawn. In the long run, it is extremely useful to be able to compact coding and save up on space.

[SirThorfinn]

Originally Posted by debussybunny563

It's nice, but there's a bug with the M1014 and Glock that you can have both out at once. I think it has to do with shooting and switching weapons at the same time; having variables governing those will eliminate that (e.g. If <shooting> == <false>, weapon.switch; Else, Do Nothing;;If <switching> == <false>, weapon.shoot; Else, Do Nothing)

Anyway, D-dog's right; in my FPS I used one method with If/Elses to determine which weapon should be drawn. In the long run, it is extremely useful to be able to compact coding and save up on space.

Ok cool, its only an experiment so i was sure there would be issues. And ill shorten the code as much as i can with your guys' idea but the Glock has a weird center point so it wouldn't work in a method like that, the other 2 would though.

[Dameria]

You can do the individual animations within the one method. You can put the exact animation to put the glock away in the same method that you put the AK47 away, you just put it in a different if/else statement away from the AK47's animation.

[debussybunny563]

Are you sure?
Because with If/Elses you can put different method for each weapon, so I wouldn't think having a different animation for the Glock would be a problem.

[Dameria]

Originally Posted by debussybunny563

Are you sure?
Because with If/Elses you can put different method for each weapon, so I wouldn't think having a different animation for the Glock would be a problem.

Wow, your post was posted at literally the exact same time as I posted my previous comment. It was so fast that when I posted mine and it refreshed this post screen, it showed my comment and then yours right underneath mine, meaning that you posted in between the time of me clicking the post button and the screen refreshing again.

Never seen that happen before

[SirThorfinn]

oh thats what you mean, i thought you men't to have all the weapons move to the same position when you take them out and put them back, my bad i know what you mean.

[debussybunny563]

Originally Posted by Dameria

Wow, your post was posted at literally the exact same time as I posted my previous comment. It was so fast that when I posted mine and it refreshed this post screen, it showed my comment and then yours right underneath mine, meaning that you posted in between the time of me clicking the post button and the screen refreshing again.

Never seen that happen before

FTW.



BTW, you're close to your 777th post.
EDIT: And this is my 515th.